[PATCH] D37985: [AMDGPU] add LDS f32 intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:303
+class AMDGPUAtomicF32IntrinNORET : Intrinsic<[],
+    [LLVMQualPointerType<llvm_float_ty, 3>, llvm_float_ty],
+    [IntrArgMemOnly, NoCapture<0>, IntrNoReturn]
----------------
dfukalov wrote:
> arsenm wrote:
> > Should this have an operand added for the ordering?
> No, these intrinsics are created by request to be able to generate ds_{add|min|max}[_rtn]_f32 in case of OpenCL local memory atomics only. They work only for pointers to floats located in addrspace 3
That doesn't change the ordering. Also needs an operand for volatile


https://reviews.llvm.org/D37985