[PATCH] D36558: [llvm-objcopy] Add support for nested and overlapping segments

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich updated this revision to Diff 115684.
jakehehrlich added a comment.

Right, the alignment trick makes perfect sense. Also I removed the error because, you're right, it only makes sense for PT_LOAD. I still think there might be an issue with some special nearly "all zero" sections but it's kind of hard to figure out how exactly they should be handled. Anything that has an offset of zero and a file size of zero will currently be handled correctly so I can't think of such a case that isn't handled correctly.


Repository:
  rL LLVM

https://reviews.llvm.org/D36558

Files:
  test/tools/llvm-objcopy/adjacent-segments.test
  test/tools/llvm-objcopy/identical-segments.test
  test/tools/llvm-objcopy/overlap-chain.test
  test/tools/llvm-objcopy/pt-phdr.test
  test/tools/llvm-objcopy/triple-overlap.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36558.115684.patch
Type: text/x-patch
Size: 19251 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170918/1e89a6c2/attachment.bin>