[PATCH] D37907: [scudo] Android build support

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: test/scudo/CMakeLists.txt:20
+    if (${arch} STREQUAL "i386")
+      set(SCUDO_TEST_TARGET_ARCH i686-android)
+    else()
----------------
vitalybuka wrote:
> Why do you need this? 
> I don't see you use it it tests or cfg files.
> In tests you can achieve the same  with:
> // XFAIL: android && i386-target-arch
So that came from my local tests.
The generated library is libclang_rt.scudo-i686-android.a for i386.
While with ${arch} being i386, when attempting to whole-archive link the library, it attempts to find libclang_rt.scudo-i386.a.
Hence me adding the -android and swapping i386 for i686.
As far as I can tell it doesn't try i386 & i686 but only i386.





================
Comment at: test/scudo/lit.site.cfg.in:6
 config.target_cflags = "@SCUDO_TEST_TARGET_CFLAGS@"
+config.android = "@ANDROID@"
 
----------------
vitalybuka wrote:
> You don't need this. Its already in the compiler-rt/test/lit.common.configured.in
I just noticed your patches.
I am updating things on my side.


https://reviews.llvm.org/D37907