[PATCH] D37971: [dwarfdump] Add verbose output for .debug-line section

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 09:13:09 PDT 2017


JDevlieghere added inline comments.


================
Comment at: test/DebugInfo/MIR/X86/empty-inline.mir:14-16
+# CHECK:                 25      0      1   0             0  is_stmt
+# CHECK:                 29     28      1   0             0  is_stmt prologue_end
+# CHECK:                 29     28      1   0             0  is_stmt end_sequence
----------------
dblaikie wrote:
> Perhaps it's worth un-verbosifying test cases when they need to be touched manually like this anyway?
That's how I got started before switching to this approach. I wasn't confident enough about the content of the verbose output not being part of the test. I definitely don't want to reduce the test quality for this kind of change. If there are tests that stick out where it would obviously not matter, I'd be more than happy to change it! 


https://reviews.llvm.org/D37971





More information about the llvm-commits mailing list