[PATCH] D37971: [dwarfdump] Add verbose output for .debug-line section

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugLine.cpp:445
+        if (OS) {
+          *OS << "DW_LNE_end_sequence\n";
+          OS->indent(12);
----------------
If we don't have one already, should probably have a DW_LNE enum stringification function generated from Dwarf.def - and use that to print the DW_LNE_* first, outside the switch, then use the switch to dump the specific parameters, if any, etc.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugLine.cpp:462
+        if (OS)
+          *OS << format("DW_LNE_set_address (0x%16.16" PRIx64 ")\n",
+                        State.Row.Address);
----------------
There's some inconsistency in whitespace (some of the printing "DW_LNE_foo (" and some without the space) - pick one for consistency.


================
Comment at: test/DebugInfo/MIR/X86/empty-inline.mir:14-16
+# CHECK:                 25      0      1   0             0  is_stmt
+# CHECK:                 29     28      1   0             0  is_stmt prologue_end
+# CHECK:                 29     28      1   0             0  is_stmt end_sequence
----------------
Perhaps it's worth un-verbosifying test cases when they need to be touched manually like this anyway?


https://reviews.llvm.org/D37971