[PATCH] D35014: [X86] PR32755 : Improvement in CodeGen instruction selection for LEAs.

[James Molloy via Phabricator via llvm-commits]

jmolloy requested changes to this revision.
jmolloy added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Target/X86/X86OptimizeLEAs.cpp:1029
+  for (auto Child : DN->getChildren())
+    FactorizeLEAsBasicBlock(Child);
+
----------------
This can cause recursion deep enough to cause stack overflows. Please could you refactor this to not use direct recursion? The domtree may be hundreds of nodes deep in degenerate cases.


https://reviews.llvm.org/D35014