[PATCH] D32840: [XRay] convert FDR arg1 log entries

[Dean Michael Berris via Phabricator via llvm-commits]

dberris requested changes to this revision.
dberris added a comment.
This revision now requires changes to proceed.

I think you need to rebase this too. :)



================
Comment at: include/llvm/XRay/YAMLXRayRecord.h:89
+template <> struct SequenceTraits<std::vector<uint64_t>> {
+  static constexpr bool flow = true;
+  static size_t size(IO &IO, std::vector<uint64_t> &V) { return V.size(); }
----------------
pelikan wrote:
> dberris wrote:
> > What is this meant to do? Is it meant to force text wrapping? If so, please don't do that (it messes with the tests and the settings that can be defined on the YAML stream instead).
> It's meant to *remove* text wrapping.  Since we only really support one argument in the list, we want it to look like "[ 1 ]", not like "[\n\t1,\n]\n" or whatever it thinks is in order.  This way each log entry will only occupy one line, as they should (both for readability and parsability).
Isn't text wrapping controlled on the stream too? Or is this different?

I guess the question is whether this is actually required, or whether this is something controllable through the serialisation instead of being hard-coded on the type.


https://reviews.llvm.org/D32840