[PATCH] D37949: [X86][XOP] Merge rotation opcodes with AVX512 equivalents. NFCI.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 17 23:47:31 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86InstrFragmentsSIMD.td:216
                                              SDTCisSameAs<0,2>]>>;
-def X86vproti  : SDNode<"X86ISD::VPROTI",
+def X86vproti  : SDNode<"X86ISD::VROTLI",
                         SDTypeProfile<1, 2, [SDTCisVec<0>, SDTCisSameAs<0,1>,
----------------
craig.topper wrote:
> Can we just replace all uses of this with X86vrotli?
We should - I hit a load of tblgen failures when I tried this in an earlier version of the patch and sort of brushed the problem under the carpet, I'll try again.


Repository:
  rL LLVM

https://reviews.llvm.org/D37949





More information about the llvm-commits mailing list