[PATCH] D37965: [XRay][compiler-rt] Handle tail-call exits in the XRay runtime

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 17 23:14:03 PDT 2017


dberris added a comment.

In https://reviews.llvm.org/D37965#873417, @pelikan wrote:

> I don't understand why do we need the version number bumped but I'm guessing you'll show me a counter-example in response to this comment.


Right, apologies if it wasn't too clear.

This one is a matter of non-backwards compatibility. We're using the version number in the log to indicate that older versions of the `llvm-xray` tools aren't expected to handle this version of the log (because we write new kinds of records here). This makes it so that when the previously built/released version of the llvm-xray tool is used on a newer version of the log, the older built tool will fail immediately on an unknown version.

I'll update the description to explain this a bit more.


https://reviews.llvm.org/D37965





More information about the llvm-commits mailing list