[PATCH] D37951: [zorg] Allow specification of svn update mode remotely

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.

This would allow people to trigger remote clobbers without having to log into a build bot.


https://reviews.llvm.org/D37951

Files:
  zorg/buildbot/builders/ClangBuilder.py


Index: zorg/buildbot/builders/ClangBuilder.py
===================================================================
--- zorg/buildbot/builders/ClangBuilder.py
+++ zorg/buildbot/builders/ClangBuilder.py
@@ -114,23 +114,23 @@
                                workdir='.'))
     else:
         f.addStep(SVN(name='svn-llvm',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/llvm/',
                       defaultBranch='trunk',
                       workdir=llvm_srcdir))
         f.addStep(SVN(name='svn-clang',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/cfe/',
                       defaultBranch='trunk',
                       workdir='%s/tools/clang' % llvm_srcdir))
         f.addStep(SVN(name='svn-clang-tools-extra',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/clang-tools-extra/',
                       defaultBranch='trunk',
                       workdir='%s/tools/clang/tools/extra' % llvm_srcdir))
         if checkout_compiler_rt:
             f.addStep(SVN(name='svn-compiler-rt',
-                          mode='update',
+                          mode=Property('mode', default='update'),
                           baseURL='http://llvm.org/svn/llvm-project/compiler-rt/',
                           defaultBranch='trunk',
                           workdir='%s/projects/compiler-rt' % llvm_srcdir))
@@ -345,52 +345,52 @@
                       checkout_libcxx):
     # We *must* checkout at least Clang+LLVM
     f.addStep(SVN(name='svn-llvm',
-                  mode='update', baseURL='http://llvm.org/svn/llvm-project/llvm/',
+                  mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/llvm/',
                   defaultBranch='trunk',
                   workdir='llvm'))
     f.addStep(SVN(name='svn-clang',
-                  mode='update', baseURL='http://llvm.org/svn/llvm-project/cfe/',
+                  mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/cfe/',
                   defaultBranch='trunk',
                   workdir='llvm/tools/clang'))
 
     # Extra stuff that will be built/tested
     if checkout_clang_tools_extra:
         f.addStep(SVN(name='svn-clang-tools-extra',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/clang-tools-extra/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/clang-tools-extra/',
                       defaultBranch='trunk',
                       workdir='llvm/tools/clang/tools/extra'))
     if checkout_compiler_rt:
         f.addStep(SVN(name='svn-compiler-rt',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/compiler-rt/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/compiler-rt/',
                       defaultBranch='trunk',
                       workdir='llvm/projects/compiler-rt'))
     if checkout_test_suite:
         f.addStep(SVN(name='svn-lnt',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/lnt/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/lnt/',
                       defaultBranch='trunk',
                       workdir='test/lnt'))
         f.addStep(SVN(name='svn-test-suite',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/test-suite/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/test-suite/',
                       defaultBranch='trunk',
                       workdir='test/test-suite'))
     if checkout_lld:
         f.addStep(SVN(name='svn-lld',
-                      mode='update', baseURL='http://llvm.org/svn/llvm-project/lld/',
+                      mode=Property('mode', default='update'), baseURL='http://llvm.org/svn/llvm-project/lld/',
                       defaultBranch='trunk',
                       workdir='llvm/tools/lld'))
     if checkout_libcxx:
         f.addStep(SVN(name='svn-libcxx',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/libcxx/',
                       defaultBranch='trunk',
                       workdir='llvm/projects/libcxx'))
         f.addStep(SVN(name='svn-libcxxabi',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/libcxxabi/',
                       defaultBranch='trunk',
                       workdir='llvm/projects/libcxxabi'))
         f.addStep(SVN(name='svn-libunwind',
-                      mode='update',
+                      mode=Property('mode', default='update'),
                       baseURL='http://llvm.org/svn/llvm-project/libunwind/',
                       defaultBranch='trunk',
                       workdir='llvm/projects/libunwind'))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37951.115548.patch
Type: text/x-patch
Size: 5367 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170916/d31a5a01/attachment.bin>