[PATCH] D37747: [MIPS] Fix PLT entries generation in case of linking regular and microMIPS code
Simon Atanasyan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 15 22:55:53 PDT 2017
atanasyan updated this revision to Diff 115531.
atanasyan added a comment.
Address review comments:
- Removed a temporary variable in the `isMicroMips` function.
- Moved `MipsEFlags` global variable to the `Config`. Calculation of its value requires iterating over all input object files so doing that each time when we call `getMipsEFlags()` is expensive.
Repository:
rL LLVM
https://reviews.llvm.org/D37747
Files:
ELF/Arch/Mips.cpp
ELF/Arch/MipsArchTree.cpp
ELF/Config.h
ELF/Writer.cpp
ELF/Writer.h
test/ELF/mips-elf-flags.s
test/ELF/mips-micro-jal.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37747.115531.patch
Type: text/x-patch
Size: 9714 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170916/ad02496c/attachment.bin>
More information about the llvm-commits
mailing list