[PATCH] D37739: [ELF] - ICF: handle SHF_LINK_ORDER sections properly.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

This seems to be another instance of attempting to "fix" an issue at surface-level where deeper planning is needed.

Current ICF doesn't actually work for SHF_LINK_ORDER, no? Assume you have three sections A, B and C, where C depends on A but B doesn't have any dependent section. Do you think A and B can be merged? No, because A and B are not really identical. The problem is that ICF doesn't take section dependencies into account. I don't want you to update this patch immediately, but can you please think about that to come up with a plan how you would deal with it and explain it to me?


https://reviews.llvm.org/D37739