[PATCH] D37920: Resubmit (Fixed) "[lit] Force site configs to be run before source tree configs"

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:352
+    # The user can still choose to have the check targets *use* a different lit
+    # by specifying -DLLVM_EXTERNAL_LIT, but we generate it regardless.
+    if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/llvm-lit)
----------------
eugenis wrote:
> What's the point of generating llvm-lit when LLVM_EXTERNAL_LIT is specified?
My thinking was mostly just "might as well".   But it's not imperative.  On the other hand, it doesn't hurt anything, and we have to do it anyway if `LLVM_EXTERNAL_LIT` is not specified.


https://reviews.llvm.org/D37920