[PATCH] D37848: [ELF] - Dedupliсate FDEs correctly when two sections are ICFed

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:454-456
+  if (!Target || !Target->Live)
+    return false;
+  return FdeMap.insert(std::make_pair(Target, getAddend<ELFT>(Rel))).second;
----------------
You are making this attribute-accessing function non-idempotent, which is generally bad. Again, instead of "fixing" a problem, you want to think harder to find out what this function should do. Please implement in a different way.


https://reviews.llvm.org/D37848