[PATCH] D37775: Add a verifier test to check the access on both sides of COPY are the same
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 15 14:28:02 PDT 2017
qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.
LGTM with one suggestion
================
Comment at: lib/CodeGen/MachineVerifier.cpp:957
+ ? DstTy.getSizeInBits()
+ : TRI->getRegSizeInBits(DstOp.getReg(), *MRI);
+ assert(SrcSize && "Expecting size here");
----------------
Seeing this pattern being actually the implementation of RegisterBankInfo::getSizeInBits, I would suggest to move the whole RegisterBankInfo::getSizeInBits directly in TargetRegisterInfo.
https://reviews.llvm.org/D37775
More information about the llvm-commits
mailing list