[PATCH] D37882: ubsan: Unbreak ubsan_cxx runtime library on Windows.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:94
 
 if(APPLE AND SANITIZER_MIN_OSX_VERSION AND SANITIZER_MIN_OSX_VERSION VERSION_LESS "10.9")
   # Mac OS X prior to 10.9 had problems with exporting symbols from
----------------
rnk wrote:
> pcc wrote:
> > rnk wrote:
> > > Is it correct to add `OR MSVC` to this list, so that the tests requiring `cxxabi` won't run on Windows?
> > The whole point of this change is to make it so that the `cxxabi` tests do run on Windows :)
> > 
> > Some of the tests use `-fsanitize=vptr`, which is disabled on Windows because it depends on a working implementation of `__ubsan::checkDynamicType`, which is not implemented on Windows. However `-fsanitize=cfi` only uses `__ubsan::getDynamicTypeInfoFromVtable` which has a Windows implementation.
> I think I misread this: "ubsan_cxx, which of course does not work directly on
> Windows" as saying that ubsan_cxx doesn't work on Windows. That's my mistake, the whole point of this change is to make it work better.
Yeah, sorry, I'll reword the commit message.


https://reviews.llvm.org/D37882