[PATCH] D37157: Fix Bug 30978 by emitting cv file checksums.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 11:10:28 PDT 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Thanks, looks good!



================
Comment at: llvm/include/llvm/MC/MCCodeView.h:302-303
+    unsigned StringTableOffset;
+    MCSymbol *
+        ChecksumTableOffset; // Stored as a symbol because it might be requested
+                             // before it has been calculated, so a fixup
----------------
Generally, if the comment describing the variable doesn't fit on one line, consider moving it before the variable. Then we won't end up with this awkard split after the `*`.


https://reviews.llvm.org/D37157





More information about the llvm-commits mailing list