[PATCH] D35987: [ELF] - Introduce std::vector<InputFile *> global arrays.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 10:39:36 PDT 2017


ruiu added a comment.

It doesn't look as bad as I first thought. It is perhaps an improvement.



================
Comment at: ELF/SymbolTable.cpp:595
+  for (InputFile *F : SharedFiles) {
+    SharedFile<ELFT> *File = cast<SharedFile<ELFT>>(F);
     for (StringRef U : File->getUndefinedSymbols()) {
----------------
Remove this temporary variable.


================
Comment at: ELF/Writer.cpp:118
 
 template <class ELFT> static bool needsInterpSection() {
+  return !SharedFiles.empty() && !Config->DynamicLinker.empty() &&
----------------
Remove template.


https://reviews.llvm.org/D35987





More information about the llvm-commits mailing list