[PATCH] D37483: AMDGPU: AMDPAL scratch buffer support

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 10:28:54 PDT 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFrameLowering.cpp:393
+    BuildMI(MBB, I, DL, SMovB32, RsrcLo)
+      .addReg(AMDGPU::SGPR0, RegState::ImplicitDefine) // Low address passed in
+      .addReg(ScratchRsrcReg, RegState::ImplicitDefine);
----------------
Why implicit def of s0? I don't think this should be necessary


https://reviews.llvm.org/D37483





More information about the llvm-commits mailing list