[PATCH] D37876: [WebAssembly] MC: Create data sections based on MCSections

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

Should the patch title be "create data *segments* based on MCSections"?



================
Comment at: lib/MC/WasmObjectWriter.cpp:515
+      if (Align->getValueSize() != 1)
+        report_fatal_error("only byte values supported for alignment");
+      // If nops are requested, use zeros, as this is the data section.
----------------
Does this mean we don't support the .p2align directive?
If so, we should have a TODO to fix it. Or do we just expect it to get converted and we should never see this (in other words, can it be an assert instead)?


https://reviews.llvm.org/D37876