[PATCH] D37882: ubsan: Unbreak ubsan_cxx runtime library on Windows.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:94
 
 if(APPLE AND SANITIZER_MIN_OSX_VERSION AND SANITIZER_MIN_OSX_VERSION VERSION_LESS "10.9")
   # Mac OS X prior to 10.9 had problems with exporting symbols from
----------------
Is it correct to add `OR MSVC` to this list, so that the tests requiring `cxxabi` won't run on Windows?


================
Comment at: compiler-rt/lib/ubsan/ubsan_handlers.cc:667-669
+WIN_WEAK_ALIAS(__ubsan_handle_cfi_bad_type, __ubsan_handle_cfi_bad_type_default)
+#else
 SANITIZER_WEAK_ATTRIBUTE
----------------
Weak functions strike again.


https://reviews.llvm.org/D37882