[PATCH] D37561: [ELF] - Don't crash when --emit-relocs is used with --gc-sections

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 02:29:22 PDT 2017


grimar added inline comments.


================
Comment at: ELF/InputSection.cpp:86-88
+  Live = !Config->GcSections;
+  if (!(Flags & SHF_ALLOC))
+    Live = Type != SHT_REL && Type != SHT_RELA;
----------------
ruiu wrote:
> This is too magical that it needs comment.
Oh, I am sorry, looks I put `=` instead of `|=` at last minute by mistake.
Fixed, added comment.


https://reviews.llvm.org/D37561





More information about the llvm-commits mailing list