[PATCH] D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/LTO.cpp:128
 
+static llvm::DenseSet<StringRef> getScriptSymbols() {
+  llvm::DenseSet<StringRef> Ret;
----------------
pcc wrote:
> I would inline this function into the caller.
Done. Thanks for review !


================
Comment at: ELF/LTO.cpp:168
       undefine(Sym);
-    R.LinkerRedefined = Config->RenamedSymbols.count(Sym);
+    // We tell LTO to not apply IPO for following symbols.
+    R.LinkerRedefined =
----------------
ruiu wrote:
> "following symbols" doesn't explain what this code is for. It's basically saying that this code does something as is written. Please update the comment.
Done.


https://reviews.llvm.org/D37059