[PATCH] D37837: Keep some relocations with undefined weak symbols

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/Driver.cpp:1012-1013
>  
> +  Config->HasDynSymTab = !SharedFile<ELFT>::Instances.empty() || Config->Pic ||
> +                         Config->ExportDynamic;
> +
> ----------------
> davide wrote:
>> Maybe you can add a comment here? I remember the rule now, but I won't in a bit :)
> Since this is computed based on other configurations, I'd move this to `setConfigs` because that's where other non-command-line parameters are set.

Unfortunately it also depends on there being a .so in the link or not,
so it has to be set after the others.

Cheers,
Rafael