[PATCH] D37852: [dwarfdump] Make .eh_frame an alias for .debug_frame

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/DIContext.h:160
 
-  virtual bool verify(raw_ostream &OS, unsigned DumpType = DIDT_All,
-                      DIDumpOptions DumpOpts = {}) {
+  virtual bool verify(raw_ostream &OS, DIDumpOptions DumpOpts = {}) {
     // No verifier? Just say things went well.
----------------
JDevlieghere wrote:
> aprantl wrote:
> > aprantl wrote:
> > > Do we want to retain the ability to verify only part of a file? E.g., `--verify --debug-info`?
> > To answer my rhetoric question: I think we do.
> This doesn't change the behavior though? Both the (explicit) DumpType argument and the member in DIDumpOptions are always set to the same value. 
Oh sorry, I overlooked that DumpType is a member of DumpOpts!


================
Comment at: tools/llvm-dwarfdump/llvm-dwarfdump.cpp:64
+static opt<bool> DumpEHFrame("eh-frame", desc("Dump the .eh_frame section"),
+                             cat(SectionCategory));
 static opt<bool> DumpUUID("uuid", desc("Show the UUID for each architecture"),
----------------
You could just declare it as alias(DumpDebuFrame) instead.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:195
+    cl::values(clEnumValN(DIDT_DebugFrame, "frame", ".debug_frame"),
+               clEnumValN(DIDT_DebugFrame, "eh", ".eh_frame")));
 
----------------
I think I would feel more comfortable if we would leave the llvm-objdump options untouched.


https://reviews.llvm.org/D37852