[PATCH] D37863: Fix bug 34608 by moving private header out of public header.WindowsManifestMerger.h should not include llvm/Config/config.h, since it is private. The include has been moved to the source instead.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 16:02:52 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL313312: Fix bug 34608 by moving private header out of public header. (authored by ecbeckmann).

Changed prior to commit:
  https://reviews.llvm.org/D37863?vs=115310&id=115314#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D37863

Files:
  llvm/trunk/include/llvm/WindowsManifest/WindowsManifestMerger.h
  llvm/trunk/lib/WindowsManifest/WindowsManifestMerger.cpp


Index: llvm/trunk/include/llvm/WindowsManifest/WindowsManifestMerger.h
===================================================================
--- llvm/trunk/include/llvm/WindowsManifest/WindowsManifestMerger.h
+++ llvm/trunk/include/llvm/WindowsManifest/WindowsManifestMerger.h
@@ -26,7 +26,6 @@
 #ifndef LLVM_INCLUDE_LLVM_SUPPORT_WINDOWS_MANIFEST_MERGER_H
 #define LLVM_INCLUDE_LLVM_SUPPORT_WINDOWS_MANIFEST_MERGER_H
 
-#include "llvm/Config/config.h"
 #include "llvm/Support/Error.h"
 
 namespace llvm {
Index: llvm/trunk/lib/WindowsManifest/WindowsManifestMerger.cpp
===================================================================
--- llvm/trunk/lib/WindowsManifest/WindowsManifestMerger.cpp
+++ llvm/trunk/lib/WindowsManifest/WindowsManifestMerger.cpp
@@ -12,6 +12,7 @@
 //===---------------------------------------------------------------------===//
 
 #include "llvm/WindowsManifest/WindowsManifestMerger.h"
+#include "llvm/Config/config.h"
 #include "llvm/Support/MemoryBuffer.h"
 
 #include <map>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37863.115314.patch
Type: text/x-patch
Size: 1006 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170914/e8732075/attachment.bin>


More information about the llvm-commits mailing list