[PATCH] D37852: [dwarfdump] Make .eh_frame a first class citizen

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 14:43:14 PDT 2017


JDevlieghere added inline comments.


================
Comment at: include/llvm/DebugInfo/DIContext.h:160
 
-  virtual bool verify(raw_ostream &OS, unsigned DumpType = DIDT_All,
-                      DIDumpOptions DumpOpts = {}) {
+  virtual bool verify(raw_ostream &OS, DIDumpOptions DumpOpts = {}) {
     // No verifier? Just say things went well.
----------------
aprantl wrote:
> aprantl wrote:
> > Do we want to retain the ability to verify only part of a file? E.g., `--verify --debug-info`?
> To answer my rhetoric question: I think we do.
This doesn't change the behavior though? Both the (explicit) DumpType argument and the member in DIDumpOptions are always set to the same value. 


Repository:
  rL LLVM

https://reviews.llvm.org/D37852





More information about the llvm-commits mailing list