[PATCH] D37863: Fix bug 34608 by moving private header out of public header.WindowsManifestMerger.h should not include llvm/Config/config.h, since it is private. The include has been moved to the source instead.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 13:01:20 PDT 2017


ecbeckmann created this revision.
Herald added a subscriber: javed.absar.

The checksums had already been placed in the IR, this patch allows
MCCodeView to actually write it out to an MCStreamer.

Move private config.h header dependency out of public header file.

Addresses Bug 34608


https://reviews.llvm.org/D37863

Files:
  clang/lib/CodeGen/CGDebugInfo.cpp
  llvm/include/llvm/IR/DIBuilder.h
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/include/llvm/MC/MCCodeView.h
  llvm/include/llvm/MC/MCObjectStreamer.h
  llvm/include/llvm/MC/MCStreamer.h
  llvm/include/llvm/WindowsManifest/WindowsManifestMerger.h
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  llvm/lib/DebugInfo/CodeView/DebugChecksumsSubsection.cpp
  llvm/lib/IR/AsmWriter.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCCodeView.cpp
  llvm/lib/MC/MCObjectStreamer.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCStreamer.cpp
  llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
  llvm/test/DebugInfo/COFF/asm.ll
  llvm/test/DebugInfo/COFF/inlining.ll
  llvm/test/DebugInfo/COFF/multifile.ll
  llvm/test/DebugInfo/COFF/simple.ll
  llvm/test/MC/AArch64/coff-debug.ll
  llvm/test/MC/COFF/cv-loc.s
  llvm/tools/llvm-readobj/COFFDumper.cpp
  llvm/unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37863.115267.patch
Type: text/x-patch
Size: 45905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170914/50861474/attachment.bin>


More information about the llvm-commits mailing list