[PATCH] D37567: [llvm-readobj] - Teach tool to report error if some section is in multiple COMDAT groups at once.

[Rafael Avila de Espindola via llvm-commits]

George Rimar <grimar at accesssoftek.com> writes:

>> Should we exit with 1 when there is an error?
>
> Usually tool uses reportError() which writes to stderr and exits with 1, but it does not seem
> this one error is so much critical. We can safely continue parsing the file until real issue happens,
> I think it is better behavior for dumping as allows to see more possible errors ? 
> That is why I did not use reportError.
>
> FWIW I just checked that GNU readelf does not stop dumping on that error either.

Sorry, I didn't mean to exit immediately. But we should probably
remember that we found a error and exit with 1 once we are done.

Cheers,
Rafael