[PATCH] D37099: Added optional validation of svn sources to Dockerfiles.

Manuel Klimek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 05:35:13 PDT 2017


klimek added inline comments.


================
Comment at: utils/docker/scripts/llvm_checksum/llvm_checksum.py:86
+
+  def read_replacing_subsitutions(file_path):
+    with open(file_path, "rb") as f:
----------------
Substitute subsitutions for substitutions.


================
Comment at: utils/docker/scripts/llvm_checksum/llvm_checksum.py:114
+      file_digest = hasher.hexdigest()
+      logging.debug("Checksum %s for file %s", file_digest, file_path)
+      files.append((file_path, file_digest))
----------------
So the main reason we hash each file is for debugging purposes?


https://reviews.llvm.org/D37099





More information about the llvm-commits mailing list