[PATCH] D37801: [x86] fix pr29061

[coby via Phabricator via llvm-commits]

coby added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:36809
+        : &X86::GR64RegClass;
+      if (RC->contains(DestReg))
+        Res = std::make_pair(DestReg, RC);
----------------
craig.topper wrote:
> Do you need to clear Res if this isn't true like we do in multiple other else cases?
It leads to in-ability to satisfy input regs:
**//error: couldn't allocate input reg for constraint '{di}'//**
so no :\.
that being said, i'm not to well familiar with this area so there might be some ways around it (i.e. Do clear, and make appropriate modifications to the subsequent code (although i'm not sure the outcome will be any 'neater')


Repository:
  rL LLVM

https://reviews.llvm.org/D37801