[llvm] r313214 - [codeview] Fold FIXME into comment, there's nothing to do. NFC

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 16:30:01 PDT 2017


Author: rnk
Date: Wed Sep 13 16:30:01 2017
New Revision: 313214

URL: http://llvm.org/viewvc/llvm-project?rev=313214&view=rev
Log:
[codeview] Fold FIXME into comment, there's nothing to do. NFC

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp?rev=313214&r1=313213&r2=313214&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp Wed Sep 13 16:30:01 2017
@@ -1277,10 +1277,10 @@ TypeIndex CodeViewDebug::lowerTypeArray(
            "codeview doesn't support subranges with lower bounds");
     int64_t Count = Subrange->getCount();
 
-    // Variable length arrays and forward declarations of arrays without a size
-    // use a count of -1. Emit a count (and overall size) or zero in these cases
-    // to match what MSVC does for array declarations with no count.
-    // FIXME: Make front-end support VLA subrange and emit LF_DIMVARLU.
+    // Forward declarations of arrays without a size and VLAs use a count of -1.
+    // Emit a count of zero in these cases to match what MSVC does for arrays
+    // without a size. MSVC doesn't support VLAs, so it's not clear what we
+    // should do for them even if we could distinguish them.
     if (Count == -1)
       Count = 0;
 




More information about the llvm-commits mailing list