[PATCH] D37686: [DAG] Consolidating Instruction->SDNode Flags propagation in one class for better code management.

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:364
+  // SDNodeFlagsAcquirer::PropagateFlagsToOperands and reset once the
+  // propagation is through.
+  bool PropagateFlagsToOperands : 1;
----------------
Okay. Somewhere we need a description of the algorithm. Something like:

When processing an instruction with X kind of flags, we set flag Y on something in order to ensure something. This maintains the invariant that whatever. Then, after doing whatever, we set /unset the flag Z.



https://reviews.llvm.org/D37686