[PATCH] D37818: [lit] Update clang and lld to use the new shared LLVMConfig stuff

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 12:39:31 PDT 2017


rnk added inline comments.


================
Comment at: llvm/utils/lit/lit/llvm/config.py:92
 
     def with_environment(self, variable, value, append_path = False):
+        if append_path:
----------------
Rather than having an optional parameter that makes this append, maybe have a new method that calls this one after doing the path appending. How about `append_environment_path(var, value)` or something?


https://reviews.llvm.org/D37818





More information about the llvm-commits mailing list