[PATCH] D37788: [ARM] builtins: Do not abort in clear_cache.

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Sorry, pressed ctrl+enter by accident.

In https://reviews.llvm.org/D37788#869943, @peter.smith wrote:

> I guess the question is whether failure of __builtin___clear_cache is sufficient to unconditionally terminate the program.


Also, what kinds of failure are we talking about...

If the conditions that this happens are usually non-exceptional because of how the OS is designed, and core applications crash, than turning off the error is a no brainer.

OTOH, if this only happens on bad user code, then I see this as an opportunity to fix their code instead.

Bottom line is: we don't need to emulate libgcc in this case, and if this helps users write better code, then Linux devs will actually thank us for that.

Makes sense?

cheers,
--renato


https://reviews.llvm.org/D37788