[PATCH] D37792: [compiler-rt] Add siginfo into SignalContext

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 11:10:55 PDT 2017


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_common.h:808
 
-  SignalContext(void *context, uptr addr, uptr pc, uptr sp, uptr bp,
-                bool is_memory_access, WriteFlag write_flag)
-      : context(context),
+  SignalContext(void *siginfo, void *context, uptr addr, uptr pc, uptr sp,
+                uptr bp, bool is_memory_access, WriteFlag write_flag)
----------------
alekseyshl wrote:
> Make it private.
I'd like to replace static create with regular constructor, but in new patch. So I'd keep it as is for now.


https://reviews.llvm.org/D37792





More information about the llvm-commits mailing list