[PATCH] D37779: Invoke GetInlineCost for legality check before inline functions in SampleProfileLoader.

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 11:07:47 PDT 2017


eraman added a comment.

Discussed this offline with Dehao. Instead of using an arbitrary threshold of 100000, it is better to piggyback on the the option in InlineCost to compute cost analysis in full. That way, if the analysis returns NeverInlineCost, Sample loader shouldn't inline. Anything else (doesn't matter if the cost >= threshold), it can do the inlining. I will refactor InlineCost.cpp to enable the feature to be used without requiring an option and Dehao will base this patch on top of that.


https://reviews.llvm.org/D37779





More information about the llvm-commits mailing list