[PATCH] D37740: [SelectionDAG] Pick correct frame index in LowerArguments

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 10:54:23 PDT 2017


bjope updated this revision to Diff 115074.
bjope added a comment.

Some fixes related to comments from Adrian Prantl:

- Strip some attributes from the test case.
- Stop test after livedebugvalues (that made it possible to relate checks to positions in the fixedStack instead of load instructions).
- Reformulated the code comment that did not take stack growth direction into consideration.
- Removed the assert comparing frame index with for the "other" BUILD_PAIR operand. I think we can live without it, as it got a little bit more complicated when taking stack growth into account.
- Factored out the "LowAddressOp" number to enhance readability.


https://reviews.llvm.org/D37740

Files:
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  test/CodeGen/PowerPC/debuginfo-stackarg.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37740.115074.patch
Type: text/x-patch
Size: 5938 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170913/1424bc9f/attachment.bin>


More information about the llvm-commits mailing list