[PATCH] D37611: [IfConversion] More simple, correct dead/kill liveness handling
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 13 10:34:41 PDT 2017
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
LGTM with nitpicks.
================
Comment at: include/llvm/CodeGen/LivePhysRegs.h:111-113
+
+ /// Remove defined registers and regmask kills from the set.
+ void stepBackwardDefs(const MachineInstr &MI);
----------------
Maybe call this `removeDefs`?
================
Comment at: include/llvm/CodeGen/LivePhysRegs.h:115-116
+
+ /// Add uses to the set.
+ void stepBackwardUses(const MachineInstr &MI);
+
----------------
Call this `addUses`?
https://reviews.llvm.org/D37611
More information about the llvm-commits
mailing list