[PATCH] D37798: Teach TargetInstrInfo::getInlineAsmLength to parse .space directives with integer arguments

[Alex Bradbury via Phabricator via llvm-commits]

asb updated this revision to Diff 115059.
asb marked an inline comment as done.
asb added a comment.

Update to address review comments from @sdardis (thanks, good catch).

The following will now produced a block with size 300+instlength:

  .space 100 # comment
  .space 200
  addi r1, r2, 3

Unsupported parameters to space will still result in the directive being ignored, e.g. `.space 1 << 20`, `.space 200+56`. I'm wary of implementing any more .size variants, we don't want to reimplement the assembly parser and the motivating use case really is to make testing easier.


https://reviews.llvm.org/D37798

Files:
  lib/CodeGen/TargetInstrInfo.cpp
  lib/Target/Mips/Mips16InstrInfo.cpp
  lib/Target/Mips/Mips16InstrInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37798.115059.patch
Type: text/x-patch
Size: 5362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170913/eeab9154/attachment.bin>