[PATCH] D37789: ThinLTO: Correctly follow aliasee references when dead stripping.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 08:18:28 PDT 2017


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM, not sure how we didn't hit this before!

This got me thinking - AliasSummary shouldn't have any refs, and in fact while the constructor takes a list of refs, we always pass in an empty list. Short of restructuring the class hierarchy so that AliasSummary doesn't have the refs member, I should at least remove that parameter from the constructor, and probably add an assert in the base class constructor that we don't have a non-empty list for an alias summary type. I'll go ahead and do that in a separate patch...


https://reviews.llvm.org/D37789





More information about the llvm-commits mailing list