[PATCH] D37796: [X86][Skylake][KNL] Updating code gen regression test to use the KNL and SKYLAKE prefixes. NFC,

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a reviewer: RKSimon.
RKSimon added a comment.

LGTM



================
Comment at: test/CodeGen/X86/bmi2-schedule.ll:4
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -print-schedule -mcpu=haswell | FileCheck %s --check-prefix=CHECK --check-prefix=HASWELL
-; RUN: llc < %s -mtriple=x86_64-unknown-unknown -print-schedule -mcpu=skylake | FileCheck %s --check-prefix=CHECK --check-prefix=HASWELL
-; RUN: llc < %s -mtriple=x86_64-unknown-unknown -print-schedule -mcpu=knl     | FileCheck %s --check-prefix=CHECK --check-prefix=HASWELL
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -print-schedule -mcpu=skylake | FileCheck %s --check-prefix=CHECK --check-prefix=SKYLAKE
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -print-schedule -mcpu=knl     | FileCheck %s --check-prefix=CHECK --check-prefix=KNL
----------------
zvi wrote:
> Can you please add a common --check-prefix to allow common CHECK:'s?
Given that these are per-target-cpu scheduler tests these are highly unlikely to be used, but won't do any harm. You could add a common prefix for HW/SKX/KNL as well if its important.


Repository:
  rL LLVM

https://reviews.llvm.org/D37796