[PATCH] D37731: [ELF] - Another fix for "Do not fail when set versions for linkerscript's symbol aliases"

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 01:32:31 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D37731#868930, @ruiu wrote:

> Why do you need an alternative solution? (Speaking of simplicity, I think both solutions seem too complicated. I don't have a clear idea at the moment, but I believe there must be some way to make this a non-issue. It seems that the existence of the problem is a signal that our architecture is not right.)


Personally I find this one slightly more preferable. It looks less intrusive for me, also I do not really like all sort of dummy values (like in first version).
Comparing these 2: I find it is simpler for understanding that untill script is processed, it's symbols are simply undefined.


https://reviews.llvm.org/D37731





More information about the llvm-commits mailing list