[PATCH] D37686: [DAG] Consolidating Instruction->SDNode Flags propagation in one class for better code management.
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 12 17:46:54 PDT 2017
hfinkel added inline comments.
================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:357
bool AnyDefined : 1;
+ bool PropagateFlagsToOperands : 1;
+ bool AcquireFlagsFromUser : 1;
----------------
These flags need comments explaining what they are and how/when they're used.
================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:664
+ // returns DAG node of SDValue present in NodeMap for
+ // a given Value.
----------------
returns -> Returns
https://reviews.llvm.org/D37686
More information about the llvm-commits
mailing list