[llvm] r313090 - [SimplifyCFG] update test comments; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 16:28:11 PDT 2017


Author: spatel
Date: Tue Sep 12 16:28:11 2017
New Revision: 313090

URL: http://llvm.org/viewvc/llvm-project?rev=313090&view=rev
Log:
[SimplifyCFG] update test comments; NFC

Modified:
    llvm/trunk/test/Transforms/SimplifyCFG/div-rem-pairs.ll

Modified: llvm/trunk/test/Transforms/SimplifyCFG/div-rem-pairs.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/SimplifyCFG/div-rem-pairs.ll?rev=313090&r1=313089&r2=313090&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/SimplifyCFG/div-rem-pairs.ll (original)
+++ llvm/trunk/test/Transforms/SimplifyCFG/div-rem-pairs.ll Tue Sep 12 16:28:11 2017
@@ -1,7 +1,8 @@
 ; RUN: opt -simplifycfg -S < %s | FileCheck %s
 
-; FIXME: Hoist the sdiv because it's safe and free.
+; We could hoist the div/rem in these tests because it's safe to do so.
 ; PR31028 - https://bugs.llvm.org/show_bug.cgi?id=31028
+; ...but since there's a separate pass for that, don't bother.
 
 define i32 @hoist_sdiv(i32 %a, i32 %b) {
 ; CHECK-LABEL: @hoist_sdiv(
@@ -30,8 +31,6 @@ end:
   ret i32 %ret
 }
 
-; FIXME: Hoist the udiv because it's safe and free.
-
 define i64 @hoist_udiv(i64 %a, i64 %b) {
 ; CHECK-LABEL: @hoist_udiv(
 ; CHECK-NEXT:  entry:
@@ -59,8 +58,6 @@ end:
   ret i64 %ret
 }
 
-; FIXME: Hoist the srem because it's safe and likely free.
-
 define i16 @hoist_srem(i16 %a, i16 %b) {
 ; CHECK-LABEL: @hoist_srem(
 ; CHECK-NEXT:  entry:
@@ -88,8 +85,6 @@ end:
   ret i16 %ret
 }
 
-; FIXME: Hoist the urem because it's safe and likely free.
-
 define i8 @hoist_urem(i8 %a, i8 %b) {
 ; CHECK-LABEL: @hoist_urem(
 ; CHECK-NEXT:  entry:




More information about the llvm-commits mailing list