[PATCH] D37762: [InstCombine] Remove single use restriction from InstCombine's explicit sinking code.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 15:17:28 PDT 2017


davide added a comment.

I think what matters in this case is the {post}dominance relation between the block of the DEF and the block(s) [potentially > 1] of the USEs.
Doing this xform when all the uses are in the same block, is, correct, but restrictive. So, I think your logic is fine, but this makes me still less convinced that we shouldn't use the dom to drive this analysis (and therefore should be a separate pass :)


https://reviews.llvm.org/D37762





More information about the llvm-commits mailing list