[PATCH] D37615: [AVR] implement the relocation of LDI and other Instructions for LLD

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 14:52:09 PDT 2017


ruiu added a comment.

This patch still seems odd. It has an unused variable and uses templates where you don't need to use that.

The test does not test the feature enough because, as I wrote, `foo`'s high address is zero.

Please fix all these oddities.


Repository:
  rL LLVM

https://reviews.llvm.org/D37615





More information about the llvm-commits mailing list