[PATCH] D37772: [LLD] [MinGW] Support dllexport on i386

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Driver.cpp:237-242
+      if (Config->Machine == I386 && Config->MinGW) {
+        if (!isDecorated(E.Name))
+          E.Name = Saver.save("_" + E.Name);
+        if (!E.ExtName.empty() && !isDecorated(E.ExtName))
+          E.ExtName = Saver.save("_" + E.ExtName);
+      }
----------------
This is pretty hairy rule, but yeah, this is probably unavoidable.


================
Comment at: COFF/Driver.cpp:728
 
+  // Handle /mingw early, since it can potentially affect how other
+  // options are handled.
----------------
Since it is an internal flag, I'd like to name this /lldmingw.


================
Comment at: COFF/Options.td:107
 def nosymtab : F<"nosymtab">;
+def mingw : F<"mingw">, HelpText<"Switch to MinGW behaviour where necessary">;
 def msvclto : F<"msvclto">;
----------------
We don't want to show a help message for an internal flag.


https://reviews.llvm.org/D37772