[PATCH] D37756: [lit] Force site configs to be run before source-tree configs

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D37756#868619, @hfinkel wrote:

> In https://reviews.llvm.org/D37756#868616, @rnk wrote:
>
> > This is awesome! phab doesn't tell you the diffstat, so I patched it in, and it is: 177 insertions(+), 788 deletions(-) Nobody understood that code anyway, so this is great.
> >
> > We should wait to gather more consensus before committing, though.
>
>
> This all sounds great. Any downsides of which we should be aware?


None that //I'm// aware of, but it's hard to deny that there's a lot of black magic and workarounds that have been baked in over the years (in part to workaround the things this patch is trying to solve "for real").

Definitely want to hear from others if there is anything they can think of.

Just to re-iterate, this should have no effect on external projects.  All I did was pipe a magic `config_map` dictionary through the builtin parameter dictionary.  If it's not there (which will be the case for non LLVM based projects), the behavior will be the same as it was before this patch


https://reviews.llvm.org/D37756