[PATCH] D37771: llvm-dwarfdump: automatically dump both regular and .dwo variant of sections

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Some thoughts/suggestions



================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:367-370
+    if (!DObj->getStringOffsetSection().Data.empty())
+      dumpStringOffsetsSection(
+          OS, "debug_str_offsets", *DObj, DObj->getStringOffsetSection(),
+          DObj->getStringSection(), isLittleEndian(), getMaxVersion());
----------------
Should this condition be sunk into dumpStringOffsetsSection?


================
Comment at: test/DebugInfo/X86/fission-no-inlining.ll:5
 ; CHECK-NOT: DW_TAG_subprogram
+; CHECK: .debug_info.dwo contents:
 
----------------
Maybe "CHECK: contents:" So it's trivially obvious it's only checking for subprogram in the debug_info section?


================
Comment at: test/DebugInfo/X86/generate-odr-hash.ll:77
 ; SINGLE-LABEL: .debug_types contents:
-; FISSION-NOT: .debug_types contents:
-; FISSION-LABEL: .debug_types.dwo contents:
+; FISSION: .debug_types contents:
 
----------------
Not following this change - it looks like it's checking for types in debug_types instead of debug_types.dwo?


================
Comment at: test/DebugInfo/X86/generate-odr-hash.ll:130
+; FISSION: .debug_line.dwo contents:
+; CHECK-NOT: .debug_line.dwo contents:
 ; FISSION: Line table prologue
----------------
Also probably "CHECK-NOT: contents:"


================
Comment at: test/DebugInfo/X86/live-debug-variables.ll:30
 ; CHECK-NOT: :
+; CHECK:      .debug_loc.dwo contents:
 
----------------
Should we print the header if there's nothing in the section? I've know we do it for some sections and not for others - and kind of think maybe we shouldn't do it for any sections.


================
Comment at: test/DebugInfo/X86/split-dwarf-multiple-cu-hash.ll:9
 ; CHECK-NOT: dwo_id {{.*}}([[HASH]])
+; CHECK: .debug_info.dwo contents:
 
----------------
CHECK: contents:


================
Comment at: test/DebugInfo/X86/split-dwarf-omit-empty.ll:21
 ; CHECK-NOT: Compile Unit
+; CHECK: .debug_info.dwo contents:
 
----------------
CHECK: contents:


https://reviews.llvm.org/D37771